-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): bump enr, discv5, secp256k1 #7000
Conversation
127a7b4
to
6d4386c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
more breaking changes 👍
lgtm, when it compiles
Blocked on @mattsse PR 😄 sigp/enr#61 |
cc @mattsse this is merged! |
6d4386c
to
ce06a6a
Compare
Looks like |
b50c3e9
to
ae66165
Compare
Looking forward for this PR to be merged. I am probably missing something, but Also, I want to point out, that currently there are 2 version of secp256k1 in dependency tree: |
Yes, that's correct, however |
@DaniPopes thank you for clarification! |
5135881
to
ac97aa0
Compare
One of the failures: sigp/enr#69 |
e28b4a3
to
9860a22
Compare
discv5 is configured to a git commit, and should remain so. for |
10815b8
to
7fb84b3
Compare
e9bbbb6
to
b01ed49
Compare
I still think enr decoding is currently broken, resulting in lots of invalid signature errors on decoding |
yes, blocked by sigp/enr#75 |
discv5 bumped sigp/discv5@e9e0d4f |
discv5 is still on |
b01ed49
to
3c14c5d
Compare
enr bumped in discv5 https://github.com/sigp/discv5/releases/tag/v0.6.0 |
3c14c5d
to
dda61e8
Compare
Co-authored-by: DaniPopes <[email protected]>
Co-authored-by: Emilia Hane <[email protected]>
KeyPair
->Keypair
Message::from_slice(&[u8])?
->Message::from_digest([u8; 32])
Blocked onenr
updating theirsecp256k1
sigp/enr#61.Blocked on adiscv5
release: sigp/discv5#244